Re: svn commit: r1418830 - in /subversion/trunk/subversion/bindings/swig: core.i python/tests/checksum.py python/tests/run_all.py
From: Daniel Shahaf <danielsh_at_apache.org>
Date: Mon, 10 Dec 2012 09:47:57 +0000
On Sun, Dec 09, 2012 at 08:05:52AM -0000, breser_at_apache.org wrote:
Typo in comment.
> + if(int(check_val) != 0):
It would be better to write:
if check_val == '0'*32
(except that the test shouldn't hardcode "32")
This will catch a digest of the wrong length, and will avoid doing type
> + self.assertRaises(AssertionError)
This line does not cause the test to fail. It returns a context manager ---
> + else:
This is an archived mail posted to the Subversion Dev mailing list.