[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: enforcing LF-normalization for svn:eol-style=native files (issue #4065)

From: Branko Čibej <brane_at_wandisco.com>
Date: Mon, 10 Dec 2012 00:31:51 +0100

On 10.12.2012 00:21, Daniel Shahaf wrote:
>> As for my 1st concern, about the slowness of the pre-commit hook
>> validation, it might be possible to make it faster if both 'svnlook
>> pg' and 'svnlook cat' would support multiple targets.
> Or if you wrote your hook script using the Python bindings. (only one
> svn_fs_open call, intra-process caches, ...)

Or you can write that pre-commit hook in C, after all, using our very
own libraries. It'll take a bit longer than doing it in Python, but much
less than trying to shoehorn something into libsvn_repos that wasn't
designed to be there.

(N.B.: Even if it /was/ in libsvn_repos, it'd just get called at the
same time as the pre-commit hook; so you'd save a fork+exec and a few
open calls, but not that much more.)

-- Brane

Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com
Received on 2012-12-10 00:32:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.