[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Replay report logs the entire session url in httpd access log

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 07 Dec 2012 14:35:55 +0000

Julian Foad <julianfoad_at_btopenworld.com> writes:

> Philip Martin <philip.martin_at_wandisco.com>
>> vijay <vijay_at_collab.net> writes:
>>>  Attached the patch and log message.
>>
>> Committed in r1418322. Thanks!
>
> Hi Philip and Vijay.
>
> Your log message:
> [[[
> * subversion/libsvn_ra_serf/replay.c
>   (svn_ra_serf__replay, svn_ra_serf__replay_range): Replace the
>     session url string with the request path portion of the url.
> ]]]
>
> leaves me thinking, "But *why* did you replace the session url string with the request path portion of the url?"
>
> Please edit the log message to say why this change was made and what it means in functional terms (like, what behaviour does it change, does it fix a bug, etc.).

I don't think a log message is the place for a detailed explanation of
why a member called 'path' should contain a path rather than a full URL.
That's the sort of documentation that should go in the code. I suppose
a log message like: "Set the handler's path member to a path instead of
a complete URL" might be better.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-12-07 15:36:32 CET

This is an archived mail posted to the Subversion Dev mailing list.