[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Add properties output param to svn_wc__db_*_get_info()?

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 4 Dec 2012 22:54:21 +0000

We already fetch the properties, but we just do an isnull check on those
columns, so it is just a case of adding yet another optional output
argument.
(I wouldn’t remove the old ones as parsing properties is not always cheap.
I know some specific users store kbytes of binary data in there and our
mergeinfo is not small either)

I’m not sure if this is the way to go though. Maybe we should store some
symlink and eol-translation info outside the properties and avoid using
properties in far more cases. But we can always do this at another point in
time.

Bert

 *From:* Julian Foad <julianfoad_at_btopenworld.com>
*Sent:* December 4, 2012 11:41 PM
*To:* Subversion Development <dev_at_subversion.apache.org>
*CC:* Bert Huijben <bert_at_qqmail.nl>
*Subject:* Add properties output param to svn_wc__db_*_get_info()?

Bert and others:

Would it be OK (performance-wise) to add optional 'properties' outputs to
the

 svn_wc__db_base_get_info()
svn_wc__db_depth_get_info()
svn_wc__db_read_info()

APIs, instead of the separate and irregular APIs we currently have for
specifically requesting the props? The point is to regularize the APIs.

I want to know if the act of including the props field in the main SQL
request would be cause for concern. Alternatively we can just issue a
second SQL stmt for the props, but within the same func, if that seems
better.

- Julian

--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-12-04 23:54:57 CET

This is an archived mail posted to the Subversion Dev mailing list.