[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1415451 [1/9] - in /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs: fs.c fs_fs.c fs_fs.h low_level.c low_level.h rep-cache.c revprops.c revprops.h util.c util.h

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Mon, 3 Dec 2012 13:20:02 +0100

On Fri, Nov 30, 2012 at 3:52 AM, Peter Samuelson <peter_at_p12n.org> wrote:

>
> [stefan2_at_apache.org]
> > * subversion/libsvn_fs_fs/util.h
> > (RECOVERABLE_RETRY_COUNT,
> [...]
> > move_into_place): lib-locally declare functions previously
> > private in fs_fs.c
>
> This is a problem - on many OSes[*], all global functions and variables
> that are not 'static', i.e., anything not file-scoped, are exported and
> available to third parties from the shared library. We don't want to
> export something like move_into_place() or read_content(), even if we
> don't declare it in a header file. This is what the fs_fs__ prefix,
> with double underscore, is for.
>

Thanks for the feedback. Refactoring fs_fs.c has only
about started. Once I managed to untangle most of it,
new interfaces (e.g. similar to svn_fs_fs__dag_*) will
be introduced.

Since that will take a while and is a preparation for the
format7 changes, I do all that work on the same dev branch.

-- Stefan^2.

-- 
Certified & Supported Apache Subversion Downloads:
*
http://www.wandisco.com/subversion/download
*
Received on 2012-12-03 13:20:35 CET

This is an archived mail posted to the Subversion Dev mailing list.