[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Error running context

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: Sun, 2 Dec 2012 09:18:50 -0500

On Sun, Dec 2, 2012 at 9:05 AM, Lieven Govaerts <svnlgo_at_mobsol.be> wrote:

> Attached the patch. ( I get paid per mail I send to this list in case
> no one noticed. ;) )

The patch looks right to me - the short-circuit to do the simple window can
clearly be called for any window regardless of offset. Perhaps we can add
this testcase to the regression tests as well?

As for the looping, didn't we put in logic to stop retrying after a number
of request failures? That's probably a reasonable thing to do...I
definitely think a very nice feature of serf is that it *will* retry (which
is helpful in flaky network situations), but it needs to stop at a certain
point. =) -- justin
Received on 2012-12-02 15:19:26 CET

This is an archived mail posted to the Subversion Dev mailing list.