Re: Regression tests FAILs with older format repositories

Philip Martin wrote:

> Julian Foad writes:
>> Philip Martin wrote:
>>> $ ./fs-test --server-minor-version=4 34
>>> lt-fs-test: ../src/subversion/libsvn_subr/dirent_uri.c:1456:
>>> svn_relpath_skip_ancestor: Assertion
>>> `relpath_is_canonical(parent_relpath)' failed.
>>
>> OK, I'll investigate that.
>
> gdb shows:
>
> #4  in prev_location(...)
>     at ../src/subversion/libsvn_fs_fs/tree.c:3246
> 3246      remainder_path = svn_relpath_skip_ancestor(copy_path, path);
> (gdb) p copy_path
> $3 = 0x7ffff7e1068e "/A/D"
> (gdb) p path
> $4 = 0x7ffff3f38728 "/A/D"
>
> We are passing fspaths to a relpath function.  The test passes in 1.7
> because svn_relpath_skip_ancestor doesn't assert that the paths are
> relpaths and works if passed fspaths.

I see you have fixed this in r1415133.  Thanks.

- Julian
Received on 2012-11-29 16:20:54 CET