[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r1414810 - dry_run_added_parent_p() - libsvn_client/merge.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 28 Nov 2012 14:50:01 -0500

On 11/28/2012 02:36 PM, Julian Foad wrote:
> C. Michael Pilato wrote:
>
>> On 11/28/2012 01:44 PM, Julian Foad wrote:
>>> If the logic is that the list of added paths is not necessarily contain
>>> all leaf nodes, then doesn't it follow that dry_run_deleted_p() also
>>> needs to be updated to check whether any parent of the path being checked
>>> is in the list?
>>
>> That's not the logic, but your question about whether dry_run_deleted_p()
>> needs a similar fix is still valid. I don't believe a change is necessary,
>> though, because it not possible with Ev1 to even convey a nested deletion.
>
> Oops, I meant to ask about dry_run_added_p().

Ah. No, that function should remain the same.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-11-28 20:50:39 CET

This is an archived mail posted to the Subversion Dev mailing list.