Re: svn commit: r1412418 - in /subversion/trunk/subversion: include/private/svn_string_private.h libsvn_subr/string.c
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 22 Nov 2012 15:08:29 +0000 (GMT)
Branko Čibej wrote:
> On 22.11.2012 10:30, Bert Huijben wrote:
It's kind to the reader if we include the issue's subject line when quoting an issue number out of context like this. Of course, if all our systems automatically annotated and hyperlinked issue number references, that wouldn't be necessary.
> +/** A self-contained memory buffer of known size.
What does that comment about scratch pools and iterpools mean?
I don't follow what characteristics this new memory buffer has, and how it compares with svn_stringbuf_t. You realize svn_stringbuf_t already supports arbitrary data with null characters in it?
svn_stringbuf_t seems to be all of this, and more because it tracks the length of the user's data separately from the allocated length. What are the advantages of this new buffer?
This is an archived mail posted to the Subversion Dev mailing list.