[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1411982 - in /subversion/branches/1.6.x: ./ STATUS subversion/libsvn_client/commit_util.c subversion/libsvn_fs_fs/fs_fs.c

From: Ben Reser <ben_at_reser.org>
Date: Wed, 21 Nov 2012 18:10:53 -0800

On Wed, Nov 21, 2012 at 2:07 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Not destroying iterpool would cause rep_write_cleanup() (pool cleanup
> handler) not to fire [according to breser], hence not call
> unlock_proto_rev(), hence not clear the "being_written" flag in the txn
> object. That object lives in the fs_fs_shared_data_t (which outlives
> svn_fs_t handles) so subsequent attempts to commit that transaction
> within the same process before clearing the pool would spuriously fail.

This is true of the fsfs change but the client change is not actually
required. See my lengthier email in response to Bert.
Received on 2012-11-22 03:11:29 CET

This is an archived mail posted to the Subversion Dev mailing list.