[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1411779 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h replay.c serf.c update.c util.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 20 Nov 2012 19:11:09 +0000 (GMT)

> Author: cmpilato

> Date: Tue Nov 20 18:34:33 2012
> New Revision: 1411779
>
> URL: http://svn.apache.org/viewvc?rev=1411779&view=rev
> Log:
> Use a 64-bit variable (rather than a 32-bit one) to hold ra_serf
> timeout values expressed in microseconds.  Overflow is uncool.

Mention here that you also changed the default timeout ...

>
> . o O ( Maybe this time I won't break the build... )
>
> * subversion/libsvn_ra_serf/serf.c
>   (DEFAULT_HTTP_TIMEOUT): Set to 5 minutes (instead of 60!).

... but in fact you changed it to 10 mins not 5.

- Julian

>   (load_config): Simplify timeout logic a bit.
>
> * subversion/libsvn_ra_serf/ra_serf.h
>   (struct svn_ra_serf__session_t): Change 'timeout' from an
>     apr_short_interval_time_t to an apr_interval_time_t.
>
> * subversion/libsvn_ra_serf/replay.c
>   (svn_ra_serf__replay_range): Change 'waittime_left' from an
>     apr_short_interval_time_t to an apr_interval_time_t.
>
> * subversion/libsvn_ra_serf/update.c
>   (finish_report): Change 'waittime_left' from an
>     apr_short_interval_time_t to an apr_interval_time_t.
>
> * subversion/libsvn_ra_serf/util.c
>   (svn_ra_serf__context_run_wait): Change 'waittime_left' from an
>     apr_short_interval_time_t to an apr_interval_time_t.

[...]
> -#define DEFAULT_HTTP_TIMEOUT 3600
> +
> +/* Default HTTP timeout (in seconds); overridden by the 'http-timeout'
> +  runtime configuration variable. */
> +#define DEFAULT_HTTP_TIMEOUT 600
Received on 2012-11-20 20:11:46 CET

This is an archived mail posted to the Subversion Dev mailing list.