[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Wrong assumption about unidiff syntax in libsvn_diff?

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 20 Nov 2012 11:25:30 +0100

I'm digging through libsvn_diff and found this snippet in diff_memory.c:

      SVN_ERR(svn_utf_cstring_from_utf8_ex2
              (&out_str,
               /* The string below is intentionally not marked for translation:
                  it's vital to correct operation of the diff(1)/patch(1)
                  program pair. */
               APR_EOL_STR "\\ No newline at end of file" APR_EOL_STR,
               btn->header_encoding, btn->pool));

I was under the impression that we already cleared up this
misconception? Only the leading backslash and space are important for
signaling the no-trailing-eoln state. The text itself can be localized,
or absent.

I'm pretty sure we should mark the "No newline at end of file" for
translation -- but /not/ the "\\ ".

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com	
Received on 2012-11-20 11:26:08 CET

This is an archived mail posted to the Subversion Dev mailing list.