[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1409186 - /subversion/trunk/subversion/libsvn_client/add.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 14 Nov 2012 18:10:57 +0100

> -----Original Message-----
> From: philip_at_apache.org [mailto:philip_at_apache.org]
> Sent: woensdag 14 november 2012 13:47
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1409186 -
> /subversion/trunk/subversion/libsvn_client/add.c
>
> Author: philip
> Date: Wed Nov 14 12:46:40 2012
> New Revision: 1409186
>
> URL: http://svn.apache.org/viewvc?rev=1409186&view=rev
> Log:
> * subversion/libsvn_client/add.c
> (svn_client__get_all_auto_props): Don't use iterpool when values must
> persist.
>
> Modified:
> subversion/trunk/subversion/libsvn_client/add.c
>
> Modified: subversion/trunk/subversion/libsvn_client/add.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/a
> dd.c?rev=1409186&r1=1409185&r2=1409186&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/libsvn_client/add.c (original)
> +++ subversion/trunk/subversion/libsvn_client/add.c Wed Nov 14 12:46:40
> 2012
> @@ -737,7 +737,7 @@ svn_client__get_all_auto_props(apr_hash_
> err = svn_client_propget5(&props, &inherited_config_auto_props,
> SVN_PROP_INHERITABLE_AUTO_PROPS, path_or_url,
> &rev, &rev, NULL, svn_depth_empty, NULL, ctx,
> - scratch_pool, iterpool);
> + scratch_pool, scratch_pool);

Hmm, since when do our functions allocate results in their scratch_pool, when they also have a result pool?

        Bert
Received on 2012-11-14 18:11:42 CET

This is an archived mail posted to the Subversion Dev mailing list.