[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1406366 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 12 Nov 2012 18:04:31 +0400

On Mon, Nov 12, 2012 at 5:59 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 11/12/2012 08:22 AM, Ivan Zhakov wrote:
>> I'm also get similar crash on Windows and MacOS. Commenting call to
>> maybe_close_dir() in handle_propchange_only()/handle_local_content()
>> fixes them, but increase memory usage.
>
> Those two call sites were "just in case" sorts of additions. Obviously,
> they didn't trigger SEGFAULTs on my end, or I wouldn't have committed them.
> But I didn't have any reason to believe they were critical to the
> memory-reduction work, so let's just remove them. (I'll do so.)
>
Without these calls memory usage is very high: checkout of
subversion/branches consumes about 200mb of memory (then crashes btw).
So we need these calls, but probably in some other place.

-- 
Ivan Zhakov
Received on 2012-11-12 15:05:23 CET

This is an archived mail posted to the Subversion Dev mailing list.