[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] enabling ruby in the subversion build

From: Michael Chletsos <mpchlets_at_gmail.com>
Date: Wed, 7 Nov 2012 16:15:48 -1000

Here is a complete patch that I tested - more work needs to be done on
the tests, but currently all tests that are run, succeed on my system.

I based this on trunk today.

On Wed, Nov 7, 2012 at 8:57 AM, Michael Chletsos <mpchlets_at_gmail.com> wrote:
> Sorry - I am having one of those morning - this one should be good, I
> keep reversing my files and my thoughts . . .
>
> I will check out trunk later and fix the patches and this patch and
> make them all nice and be real.
>
>
>
> On Wed, Nov 7, 2012 at 8:54 AM, Peter Samuelson <peter_at_p12n.org> wrote:
>>
>> [Michael Chletsos]
>>> sorry about confusion - here is the updated patch, with swig updates.
>>
>> Your patch seems to be reversed ('diff -u {new} {old}' whereas what
>> everyone wants to see is 'diff -u {old} {new}' or 'svn diff'), and also
>> seems to have been developed against something older than Subversion
>> trunk. I note for example that you change some Config to RbConfig, a
>> change that was made in Subversion trunk months ago in r1337514.
>>
>> Please update your Subversion checkout to the current trunk, apply your
>> patch, then run 'svn diff' to generate a more current patch.
>>
>> Peter

Received on 2012-11-08 03:16:20 CET

This is an archived mail posted to the Subversion Dev mailing list.