Re: svn commit: r1405517 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp SVNClient.cpp StringArray.cpp Targets.cpp

On Nov 4, 2012, at 2:14 AM, stefan2_at_apache.org wrote:

> Author: stefan2
> Date: Sun Nov 4 10:14:56 2012
> New Revision: 1405517
>
> URL: http://svn.apache.org/viewvc?rev=1405517&view=rev
> Log:
> Silence integer size conversion warnings in JavaHL under Win64 by casting
> the values explicitly. We assume that argument counts and property sizes
> are all well below the 2G limit.

Hi Stefan,

Since you're in C++ here you could switch to using static_cast<> or reinterpret_cast<> instead, that would be better for self documentation, although that doesn't seem to be the style in the code.

Blair
Received on 2012-11-04 12:37:42 CET