[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add platform information to user agent string

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Fri, 2 Nov 2012 15:36:13 +0400

On Wed, Oct 31, 2012 at 2:04 AM, Branko Čibej <brane_at_wandisco.com> wrote:
[..]
>
> The sysinfo bits have static (build-time) info and dynamic (runtime)
> info. Presumably the only difference will be noticing when you're
> running the program on a different "size" of OS, e.g., running 32-bit
> code on a 64-bit OS (hopefully in some compatibility mode).
>
> For the purpose of user agent strings, the host triplet exposed in the
> #define in svn_private_config.h should be more than good enough.
>
I agree that using autoconf to collect OS type is much better. But I
think we should use $target, instead of $host for user-agent to
support cross compile scenarios. Also I've checked $target_os for our
build bots and their values are:
* OpenBSD: 'i386-unknown-openbsd5.0' ($target_os = 'openbsd5.0',
$target_vendor='unknown')
* Centos: 'x86_64-redhat-linux-gnu' ($target_os='linux-gnu';
$target_vendor='redhat')
* Ubuntu: ''x86_64-unknown-linux-gnu'' ($target_os=''linux-gnu'';
$target_vendor='unknown')

I've also googled for different autoconf outputs:
* MacOS: 'x86_64-apple-darwin11.2.0'
* cygwin: 'i686-pc-cygwin'
* mingw: 'i686-pc-mingw32'

We can use all $target triplet in user-agent or just $target_os. I
have no opinion on this matter. Any thoughts?

-- 
Ivan Zhakov
Received on 2012-11-02 12:37:04 CET

This is an archived mail posted to the Subversion Dev mailing list.