[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 1 Nov 2012 22:32:03 +0200

Prabhu Gnana Sundar wrote on Thu, Nov 01, 2012 at 23:59:44 +0530:
>
>
> Julian Foad <julianfoad_at_btopenworld.com> wrote:
>
> >Prabhu Gnana Sundar <prabhugs_at_collab.net> wrote:
> >
> >> Julian Foad <julianfoad_at_btopenworld.com> wrote:
> >>> At the very least there must be agreement on how it's going to exit
> >and
> >>> commitment to make it happen.  I already asked the question several
> >>> messages back.  Prabhu, please share your thoughts.
> >>
> >> Yeah Julian, once an error is encountered, the error message is
> >notified and the
> >> exit code is non zero.
> >
> >What?  Are you talking about an existing version of your patch or
> >stating your intentions for the future?
>
> I am talking about the existing version of my patch.
>
>
>   Are you talking about an error
> >message to be printed at the end (when the command exits), or the error
> >message per revision? 
>
> When a verification failure is encountered, the error message is notified for that particular revision and the verification process continues iff --keep-going is true. Finally the command exits with a exit code which is non-zero.

No, it doesn't.

% $svnadmin verify --keep-going r ; echo $?
subversion/libsvn_fs/fs-loader.c:500: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:10227: (apr_err=160006)
subversion/libsvn_fs_fs/tree.c:608: (apr_err=160006)
subversion/libsvn_fs_fs/dag.c:611: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:3019: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:1877: (apr_err=160006)
svnadmin: E160006: No such revision 0
subversion/libsvn_repos/dump.c:983: (apr_err=160006)
subversion/libsvn_fs/fs-loader.c:858: (apr_err=160006)
subversion/libsvn_fs_fs/tree.c:608: (apr_err=160006)
subversion/libsvn_fs_fs/dag.c:611: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:3019: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:1877: (apr_err=160006)
svnadmin: Error verifying revision 0: E160006: No such revision 0
subversion/libsvn_repos/dump.c:983: (apr_err=160006)
subversion/libsvn_fs/fs-loader.c:858: (apr_err=160006)
subversion/libsvn_fs_fs/tree.c:608: (apr_err=160006)
subversion/libsvn_fs_fs/dag.c:611: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:3019: (apr_err=160006)
subversion/libsvn_fs_fs/fs_fs.c:1877: (apr_err=160006)
svnadmin: Error verifying revision 1: E160006: No such revision 1
0
Received on 2012-11-01 21:32:42 CET

This is an archived mail posted to the Subversion Dev mailing list.