Re: [PATCH] Implement svnadmin verify --force

On Thu, Nov 01, 2012 at 05:40:02PM +0200, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Thu, Nov 01, 2012 at 17:37:53 +0200:
> > That discussion is perfectly within the scope of the current patch:
> > notifying the errors and clearing them _causes_ svn to return non-zero
> > exit code when it encounters a verification error.
> >
> > IOW, the patch causes a regression in the "verification errors cause
> > non-zero exit code" behaviour.
>
> Or, rather, it causes svn to exit(0) despite having printed something to
> stderr. I think it'll be better to exit(1) in that case.

OK, good catch. I agree that exit code behaviour shouldn't be changed.
Received on 2012-11-01 16:53:57 CET