[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 1 Nov 2012 10:29:35 -0400

On 11/01/2012 10:17 AM, Julian Foad wrote:
> That's easily readable, but I don't like it: it's a funny mixture of styles. We should choose either "notification" style (that is, messages that are not error messages), such as
>
> * Verified revision 0.
> * Verified revision 1.
> * Verified revision 2.
> * Error verifying revision 3: Missing node-id in node-rev at r3 (offset 787)
> * Error verifying revision 4: zlib (uncompress): corrupt data: Decompression of svndiff data failed
> * Verified revision 5.
>
> or "error messages" style, in which case the messages should be formatted like all svn err msgs, for example:
>
> * Verified revision 0.
> * Verified revision 1.
> * Verified revision 2.
> svnadmin: E199999: Error verifying revision 3
> svnadmin: E160004: Missing node-id in node-rev at r3 (offset 787)
> svnadmin: E199999: Error verifying revision 4
> svnadmin: E140001: zlib (uncompress): corrupt data: Decompression of svndiff data failed
> * Verified revision 5.

Agreed. And for what it's worth, I like the second form, especially if the
errorful lines go to stderr.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-11-01 15:30:12 CET

This is an archived mail posted to the Subversion Dev mailing list.