Re: [PATCH] Add platform information to user agent string

On Wed, Oct 31, 2012 at 12:25:43AM +0400, Ivan Zhakov wrote:
> I completely agree that it would be great to have one code to get
> platform information. But current svn_sysinfo* implementation provides
> detailed information which very expensive to obtain. In some codepath
> we have to execute external commands. This is fine for separate
> command, but I think that's does makes sense for every Subversion
> library call. That's why I suggest use static build time information
> in user-agent string.

Running uname is too expensive?
Can you show some benchmark numbers to back this up? :)

If it is prohibitively expensive perhaps you could use a global
variable to store the OS name and set it up at startup with
svn_atomic__init_once()?
Received on 2012-10-30 22:47:04 CET