Re: [PATCH] Add platform information to user agent string

Ivan Zhakov wrote:

> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote:
>> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote:
>>> I think it will be useful to add client platform information to user
>>> agent string, to use it Apache HTTP Server configuration or Subversion
>>> hooks. Within my patch applied user agent will be like this:
>>> SVN/1.8.0 (Windows) serf/1.1.1 TortoiseSVN/1.8.0
>>> SVN/1.8.0 (Macintosh) serf/1.1.1
>>> SVN/1.8.0 (FreeBSD) serf/1.1.1
>>
>> Useful how?
> For example to disable plain-text basic authentication on Windows. Or
> disable commits from Linux using pre-commit hook.

(1) Brane has recently added platform identification to the 'svn --version' command; is there any reason to use different code here producing a different set of platform identifiers?  It would seem much better to share that code -- whether using just the 'platform' string or the whole 'platform-cpu-vendor' (or whatever it is) tuple -- so that the two sets of client identifiers cannot get out of sync.

(2) C-Mike Pilato (?) has recently added some sort of ability for pre-commit hooks to see more information (via txn-rev-props), which AFAIK was partly intended to let the hook see more info about the client platform.  I don't know exactly what it does, but isn't that a more suitable place to put any new extensions of this kind of functionality?

How does what you're proposing relate to those two developments?

- Julian
Received on 2012-10-30 19:16:20 CET