[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: EAGAIN handling in libsvn_ra_serf

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 29 Oct 2012 19:30:51 -0400

On 10/29/2012 05:31 PM, Philip Martin wrote:
> In several places in ra_serf I see the pattern:
>
> /* Skip on to the next iteration of this loop. */
> if (APR_STATUS_IS_EAGAIN(status))
> {
> return svn_ra_serf__wrap_err(status, NULL);
> }
> continue;
>
> Is that test correct? It causes EAGAIN to be returned and any other
> error to continue the loop which seems to contradict the comment. I
> suppose EAGAIN could be handled at some higher level but simply
> continuing on all other errors looks wrong.

Some crazy high percentage of ra_serf seems to be implemented as callbacks
for Serf itself, and I know Serf cares a good deal about EAGAIN, so perhaps
these call sites are just deferring the handling of that condition into the
appropriate hands?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-10-30 00:31:27 CET

This is an archived mail posted to the Subversion Dev mailing list.