[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 27 Oct 2012 22:24:13 +0200

> Index: subversion/libsvn_fs/fs-loader.c
> ===================================================================
> --- subversion/libsvn_fs/fs-loader.c (revision 1402414)
> +++ subversion/libsvn_fs/fs-loader.c (working copy)
> @@ -487,17 +487,21 @@
> void *cancel_baton,
> svn_revnum_t start,
> svn_revnum_t end,
> + svn_boolean_t keep_going,
> apr_pool_t *pool)
> {
> - fs_library_vtable_t *vtable;
> - svn_fs_t *fs;
> + if (!keep_going)
> + {

That's wrong for the same reason as last time

> + fs_library_vtable_t *vtable;
> + svn_fs_t *fs;
>
> - SVN_ERR(fs_library_vtable(&vtable, path, pool));
> - fs = fs_new(NULL, pool);
> + SVN_ERR(fs_library_vtable(&vtable, path, pool));
> + fs = fs_new(NULL, pool);
>
> - SVN_MUTEX__WITH_LOCK(common_pool_lock,
> - vtable->verify_fs(fs, path, cancel_func, cancel_baton,
> - start, end, pool, common_pool));
> + SVN_MUTEX__WITH_LOCK(common_pool_lock,
> + vtable->verify_fs(fs, path, cancel_func, cancel_baton,
> + start, end, pool, common_pool));
> + }
> return SVN_NO_ERROR;
> }
Received on 2012-10-27 22:24:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.