[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] auto-props-sdc Branch : Ready for Review

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 26 Oct 2012 16:06:39 +0100

"C. Michael Pilato" <cmpilato_at_collab.net> writes:

> On 10/26/2012 10:33 AM, Philip Martin wrote:
>> Paul Burba <ptburba_at_gmail.com> writes:
>>
>>>> It's been almost two weeks with no objections, so I will be merging
>>>> this branch back to trunk today.
>>>
>>> Done, r1401908.
>>
>> This causes autoprop_tests.py to fail on my Linux box and the centos
>> buildbot:
>>
>> http://ci.apache.org/builders/svn-x64-centos-gcc/builds/7466
>>
>> I see "svn add" getting a SEGV.
>
> Of particular utility would be some indication of where the SEGV occurs, if
> you have time and inclination to determine as much, Philip. I was unable to
> reproduce the SEGV on my Linux system, and Paul runs Windows.

I'm getting:

$ gdb -arg ../../svn/.libs/lt-svn add --config-dir /home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/local_tmp/autoprops_config_autoprop_tests-2 svn-test-work/working_copies/autoprop_tests-2/escapetest --password rayjandom --no-auth-cache --username jrandom

Program received signal SIGSEGV, Segmentation fault.
memcpy () at ../sysdeps/x86_64/memcpy.S:526
526 ../sysdeps/x86_64/memcpy.S: No such file or directory.
        in ../sysdeps/x86_64/memcpy.S

#0 memcpy () at ../sysdeps/x86_64/memcpy.S:526
#1 0x00007ffff700b22a in svn_string_ncreate (bytes=0x67a1a0 ";;val",
    size=6795344, pool=0x6792b8) at ../src/subversion/libsvn_subr/string.c:165
#2 0x00007ffff700b41c in svn_string_dup (original_string=0x67afc8,
    pool=0x6792b8) at ../src/subversion/libsvn_subr/string.c:224
#3 0x00007ffff6ffc50d in svn_prop_diffs (propdiffs=0x7fffffffdac8,
    target_props=0x67be48, source_props=0x67c008, pool=0x6792b8)
    at ../src/subversion/libsvn_subr/properties.c:225
#4 0x00007ffff7907e68 in set_props_txn (baton=0x7fffffffdc90,
    wcroot=0x6950d0, local_relpath=0x67bff8 "escapetest",
    scratch_pool=0x6792b8) at ../src/subversion/libsvn_wc/wc_db.c:5139
#5 0x00007ffff7929338 in run_txn (baton=0x7fffffffdc20, db=0x694948,
    scratch_pool=0x6792b8) at ../src/subversion/libsvn_wc/wc_db_util.c:188
#6 0x00007ffff70059fb in svn_sqlite__with_lock (db=0x694948,
    cb_func=0x7ffff79292ef <run_txn>, cb_baton=0x7fffffffdc20,
    scratch_pool=0x6792b8) at ../src/subversion/libsvn_subr/sqlite.c:1073
#7 0x00007ffff79293ae in svn_wc__db_with_txn (wcroot=0x6950d0,
    local_relpath=0x67bff8 "escapetest",
    cb_func=0x7ffff7907db5 <set_props_txn>, cb_baton=0x7fffffffdc90,
    scratch_pool=0x6792b8) at ../src/subversion/libsvn_wc/wc_db_util.c:210
#8 0x00007ffff790817b in svn_wc__db_op_set_props (db=0x693718,
    local_abspath=0x679570 "/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/working_copies/autoprop_tests-2/escapetest", props=0x67be48,
    clear_recorded_info=0, conflict=0x0, work_items=0x0, scratch_pool=0x6792b8)
    at ../src/subversion/libsvn_wc/wc_db.c:5189
#9 0x00007ffff78d7b3d in do_propset (db=0x693718,
    local_abspath=0x679570 "/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/working_copies/autoprop_tests-2/escapetest", kind=svn_node_file,
    name=0x67a2a8 "myval", value=0x67afc8, skip_checks=0, notify_func=0,
    notify_baton=0x0, scratch_pool=0x6792b8)
    at ../src/subversion/libsvn_wc/props.c:1941
#10 0x00007ffff78d815e in svn_wc_prop_set4 (wc_ctx=0x693700,
    local_abspath=0x679570 "/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/working_copies/autoprop_tests-2/escapetest",
    name=0x67a2a8 "myval", value=0x67afc8, depth=svn_depth_empty,
    skip_checks=0, changelist_filter=0x0, cancel_func=0, cancel_baton=0x0,
    notify_func=0, notify_baton=0x0, scratch_pool=0x6792b8)
    at ../src/subversion/libsvn_wc/props.c:2073
#11 0x00007ffff7b66ab3 in add_file (
    local_abspath=0x679570 "/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/working_copies/autoprop_tests-2/escapetest",
    magic_cookie=0x679b18, autoprops=0x0, ctx=0x693648, pool=0x6792b8)
    at ../src/subversion/libsvn_client/add.c:327
#12 0x00007ffff7b68465 in add (
    local_abspath=0x679570 "/home/pm/sw/subversion/obj/subversion/tests/cmdline/svn-test-work/working_copies/autoprop_tests-2/escapetest",
    depth=svn_depth_infinity, force=0, no_ignore=0,
    existing_parent_abspath=0x0, ctx=0x693648, scratch_pool=0x6792b8)
    at ../src/subversion/libsvn_client/add.c:1031
#13 0x00007ffff7b689c5 in svn_client_add4 (
    path=0x694850 "svn-test-work/working_copies/autoprop_tests-2/escapetest",
    depth=svn_depth_infinity, force=0, no_ignore=0, add_parents=0,
    ctx=0x693648, pool=0x6792b8) at ../src/subversion/libsvn_client/add.c:1156

valgrind reports:

==15116== Conditional jump or move depends on uninitialised value(s)
==15116== at 0x4E3A6DF: svn_client__get_paths_auto_props (add.c:244)
==15116== by 0x4E3A914: add_file (add.c:300)
==15116== by 0x4E3C464: add (add.c:1031)
==15116== by 0x4E3C9C4: svn_client_add4 (add.c:1156)
==15116== by 0x40787B: svn_cl__add (add-cmd.c:77)
==15116== by 0x41A166: sub_main (main.c:2735)
==15116== by 0x41A372: main (main.c:2790)
==15116==
==15116== Source and destination overlap in memcpy(0x9e3f078, 0x98aca80, 160094512)
==15116== at 0x4C25F6A: memcpy (mc_replace_strmem.c:497)
==15116== by 0x5A25229: svn_string_ncreate (string.c:165)
==15116== by 0x5A2541B: svn_string_dup (string.c:224)
==15116== by 0x5A1650C: svn_prop_diffs (properties.c:225)
==15116== by 0x513DE67: set_props_txn (wc_db.c:5139)
==15116== by 0x515F337: run_txn (wc_db_util.c:188)
==15116== by 0x5A1F9FA: svn_sqlite__with_lock (sqlite.c:1073)
==15116== by 0x515F3AD: svn_wc__db_with_txn (wc_db_util.c:210)
==15116== by 0x513E17A: svn_wc__db_op_set_props (wc_db.c:5189)
==15116== by 0x510DB3C: do_propset (props.c:1941)
==15116== by 0x510E15D: svn_wc_prop_set4 (props.c:2073)
==15116== by 0x4E3AAB2: add_file (add.c:327)
==15116==
^Z==15116== Invalid read of size 1
==15116== at 0x4C25F98: memcpy (mc_replace_strmem.c:497)
==15116== by 0x5A25229: svn_string_ncreate (string.c:165)
==15116== by 0x5A2541B: svn_string_dup (string.c:224)
==15116== by 0x5A1650C: svn_prop_diffs (properties.c:225)
==15116== by 0x513DE67: set_props_txn (wc_db.c:5139)
==15116== by 0x515F337: run_txn (wc_db_util.c:188)
==15116== by 0x5A1F9FA: svn_sqlite__with_lock (sqlite.c:1073)
==15116== by 0x515F3AD: svn_wc__db_with_txn (wc_db_util.c:210)
==15116== by 0x513E17A: svn_wc__db_op_set_props (wc_db.c:5189)
==15116== by 0x510DB3C: do_propset (props.c:1941)
==15116== by 0x510E15D: svn_wc_prop_set4 (props.c:2073)
==15116== by 0x4E3AAB2: add_file (add.c:327)
=

-- 
Join us this October at Subversion Live 2012
http://www.wandisco.com/svn-live-2012
Received on 2012-10-26 17:07:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.