[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement svnadmin verify --force

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 21 Oct 2012 18:22:03 +0200

Stefan Sperling wrote on Sun, Oct 21, 2012 at 18:08:27 +0200:
> On Sun, Oct 21, 2012 at 05:47:28PM +0200, Daniel Shahaf wrote:
> > Please address my earlier review question, asking why this needs to be
> > implemented in the library and can't be done satisfactorily in user
> > (C or Python) code.
>
> Well... let me turn this around on you and ask:
> Why should it not be in the library?
> You're implying that there is some good, apparently self-evident,
> reason that it should not be done in the library. When asking others
> to argue against that it helps to explain your own reasoning first.
>

All svn_repos_verify_fs2() is a big for loop (start_rev..end_rev),
so I don't see in what way Prabhu's patch is preferable to calling
svn_repos_verify_fs2() in a loop from user code.

I might think differently if Prabhu says he already wrote
a verify-keep-going.py a year ago, has been using it since, and decided
it's so useful it belongs in the core. But I don't know that to be the
case.
Received on 2012-10-21 18:22:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.