[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1399582 - /subversion/trunk/subversion/libsvn_ra_serf/util_error.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 18 Oct 2012 19:02:07 +0100 (BST)

Ivan Zhakov wrote:

>> Author: stsp
>> Date: Thu Oct 18 11:31:20 2012
>> New Revision: 1399582
>>
>> URL: http://svn.apache.org/viewvc?rev=1399582&view=rev
>> Log:
>> * subversion/libsvn_ra_serf/util_error.c: Include ra_serf.h which contains
>>     prototypes for functions implemented in this file.
[...]
>> +#include "libsvn_ra_serf/ra_serf.h"
>> +

> Hi Stefan.
>
> Thanks for fixing this. Btw we use just "ra_serf.h" in other places.

Actually it does matter: the search path for includes contains the 'subversion' subdirectory of the *build tree* so this only works as written when building in the source tree.

When including a local header, just use its basename.

I fixed this (and the same problem with some includes in libsvn_wc/tree_conflict_editor.c) in r1399749.

- Julian
Received on 2012-10-18 20:02:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.