On Tue, Oct 16, 2012 at 12:55 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name>wrote:
> stefan2_at_apache.org wrote on Sun, Jun 10, 2012 at 21:34:22 -0000:
> > Author: stefan2
> > Date: Sun Jun 10 21:34:21 2012
> > New Revision: 1348666
> > URL: http://svn.apache.org/viewvc?rev=1348666&view=rev
> > Log:
> > When handing out node contents, the delta streams don't need
> > to calculate MD5 checksums as the result will not be used and the
> > check would be redundant even if it were made.
> > Thus, rev the svn_txdelta API to calculate the checksum only
> > upon specific request and update all callers to use the new API.
> > Modified: subversion/trunk/subversion/include/svn_delta.h
> > URL:
> > --- subversion/trunk/subversion/include/svn_delta.h (original)
> > +++ subversion/trunk/subversion/include/svn_delta.h Sun Jun 10 21:34:21
> > @@ -367,10 +367,26 @@ svn_txdelta_md5_digest(svn_txdelta_strea
> > + * If @a calculate_checksum
> > + * is set, you may call @ref svn_txdelta_md5_digest to get an MD5
> > + * for @a target.
> > *
> > * Do any necessary allocation in a sub-pool of @a pool.
> > + *
> > + * @since New in 1.8.
> > + */
> > +void
> > +svn_txdelta2(svn_txdelta_stream_t **stream,
> > + svn_stream_t *source,
> > + svn_stream_t *target,
> > + svn_boolean_t calculate_checksum,
> As of today, only svn_txdelta() and window-test.c pass TRUE for @a
> calculate_checksum. Do we anticipate needing to pass TRUE For it in any
> new code?
No, I don't anticipate extra need for that parameter
neither do I feel that it is useless. How would you
implement svn_txdelta() without that parameter?
> If not, we could take this opportunity to remove this parameter from the
> public API (it's a trivial patch).
If we can do without, I'd say let's lose the parameter
and make old and new API only differ in behavior.
> > + apr_pool_t *pool);
> > +
> > +/** Similar to svn_txdelta2 but always calculating the target checksum.
> > + *
> > + * @deprecated Provided for backward compatibility with the 1.7 API.
> > */
> > +SVN_DEPRECATED
> > void
> > svn_txdelta(svn_txdelta_stream_t **stream,
> > svn_stream_t *source,
Join us this October at Subversion Live
for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
Received on 2012-10-18 02:56:45 CEST