[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1399064 - in /subversion/trunk/subversion/bindings/javahl: native/ src/org/apache/subversion/javahl/

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Tue, 16 Oct 2012 21:44:59 -0400

On Tue, Oct 16, 2012 at 9:36 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>>
>> On Oct 16, 2012, at 9:25 PM, "Hyrum Wright" <hwright_at_apache.org> wrote:
>>
>>> On Tue, Oct 16, 2012 at 9:19 PM, <hwright_at_apache.org> wrote:
>>>> Author: hwright
>>>> Date: Wed Oct 17 01:19:21 2012
>>>> New Revision: 1399064
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1399064&view=rev
>>>> Log:
>>>> JavaHL: Punch additional changelist parameter for property fetching to
>>>> the Java layer.
>>>>
>>>> [ in subversion/bindings/javahl/ ]
>>>> * native/SVNClient.cpp,
>>>> native/SVNClient.h
>>>> (SVNClient::propertyGet): Add changelists param.
>>>>
>>>> * native/org_apache_subversion_javahl_SVNClient.cpp
>>>> (Java_org_apache_subversion_javahl_SVNClient_propertyGet):
>>>> Add changelists param, pass to C++ layer.
>>>>
>>>> * src/org/apache/subversion/javahl/ISVNClient.java,
>>>> src/org/apache/subversion/javahl/SVNClient.java
>>>> (propertyGet): Add overload to accept changelists param.
>>>
>>> Mark,
>>> This revision doesn't provide a way to return the inherited props,
>>> which the underlying API does. Right now the obvious method is a new
>>> return object which contains both the property and any inherited
>>> props, but I'd hate to create an object with just two fields. Any
>>> other suggestions?
>
>
> How about returning a Map where the path is key?

Well, we have to return both the existing property *and* the inherited
props. I don't think a Map will meet those criteria.

-Hyrum
Received on 2012-10-17 03:45:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.