Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

Philip Martin <philip.martin_at_wandisco.com> writes:

> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
>> On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name>wrote:
>>
>>> (It also has the pretty odd side effect that it's not safe to run
>>> 'svnadmin1.7 setrevprop' and 'svnadmin1.8 dump' concurrently on the
>>> same repository...)
>>>
>>
>> That's a misrepresentation of what is going on.
>>
>> Running svnadmin setrevprop and svnadmin dump
>> concurrently, has never had a well-defined behavior.
>> I.e. the propset may or may not have shown up in
>> the dump (basically a race condition).
>
> That's a bug in 1.7. When the r1237779 backport is approved 1.7 will be
> using the atomic revprop mechanism for load, and since it already uses
> the atomic mechanism for setrevprop any race will be detected and the
> second operation will fail.

Oops! My mistake. I read that as "setrevprop and svnadmin load" and
wanted to point out that while 1.7 load isn't atomic it should be.

-- 
Join us this October at Subversion Live 2012
http://www.wandisco.com/svn-live-2012