Re: svn commit: r1396744 - in /subversion/branches/http-dynamic-prop-namespaces/subversion/libsvn_ ra_serf: ra_serf.h xml.c

cmpilato_at_apache.org wrote on Wed, Oct 10, 2012 at 19:07:58 -0000:
> + * Add the appropriate serf buckets to AGG_BUCKET representing xml tag open
> + * with name TAG and attributes ATTRS. XML-escape attributes as necessary.

> +svn_ra_serf__add_open_tag_attrs_buckets(serf_bucket_t *agg_bucket,
> + serf_bucket_alloc_t *bkt_alloc,
> + const char *tag,
> + apr_hash_t *attrs);
> +
...
> + apr_hash_this(hi, &key, &klen, &val);
> +
> + tmp = SERF_BUCKET_SIMPLE_STRING(val, bkt_alloc);
> + serf_bucket_aggregate_append(agg_bucket, tmp);

It doesn't seem to be XML-escaping the value as promised in the
docstring? (Maybe that's intended for a subsequent commit...?)
Received on 2012-10-10 21:35:57 CEST