[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: warnings in fsfs-reorg.c

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Wed, 10 Oct 2012 19:09:37 +0200

On Tue, Oct 9, 2012 at 10:19 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:

> I haven't built trunk in a couple of weeks. I'm catching up now, and I
> see a lot of new warnings coming from fsfs-reorg.c (compiled with
> Visual C Express 2008 on WinXP). Stefan (or anyone else), can you take
> a look at these?
>

Yes, I can. But maybe not before the weekend.
As long as your repository does not contain pack
files > 4GB, you should be safe. If it does,
changes are that you will run out of memory
on that repo anyway ;)

BTW, that code is not supposed to be *ever*
used for production data.

> [[[
> ..\..\..\tools\server-side\fsfs-reorg.c(340): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'apr_size_t', possible
> loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(342): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(562): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(726): warning C4244: 'return'
> : conversion from 'const apr_int64_t' to 'int', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(800): warning C4244: 'return'
> : conversion from 'const apr_int64_t' to 'int', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(857): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'size_t', possible loss
> of data
> ..\..\..\tools\server-side\fsfs-reorg.c(865): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'size_t', possible loss
> of data
> ..\..\..\tools\server-side\fsfs-reorg.c(949): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(986): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'apr_size_t', possible
> loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1324): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1380): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1525): warning C4244: '+=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1597): warning C4244: '+=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1608): warning C4244: '+=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1616): warning C4244: '+=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1618): warning C4244: '+=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1664): warning C4244: '+=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1879): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1960): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(1962): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(2074): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'apr_size_t', possible
> loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(2243): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(2280): warning C4244: '=' :
> conversion from 'apr_int64_t' to 'apr_size_t', possible loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(2285): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'apr_size_t', possible
> loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(2344): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'apr_size_t', possible
> loss of data
> ..\..\..\tools\server-side\fsfs-reorg.c(2477): warning C4244:
> 'function' : conversion from 'apr_int64_t' to 'apr_size_t', possible
> loss of data
> ]]]
>
> Cheers,
> --
> Johan
>

Would be nice if people could use it to test /
evaluate the results. The hole idea is to verify
the method before attempting significant changes
to the FSFS layer in 1.9.

-- Stefan^2.

-- 
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*
Received on 2012-10-10 19:10:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.