[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

crash in latest release

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 09 Oct 2012 21:49:42 +0200


Just got the first crash report for the TSVN 1.7.10 release (svn 1.7.7).
Considering that the release is only an hour old, that indicates that I
will get a lot more of those...

Problem in libsvn_subr/win32_crypto.c, function
windows_password_decrypter(svn_boolean_t *done, ...):

   if (!done)
     return SVN_NO_ERROR;

now here the check is for the pointer, not the actual bool value.
And if it's set to false, the pointer check is still true and the code
goes on instead of returning here.

trunk and 1.7.x have the same bug, even though on trunk the code before
the if() is slightly different.

I think this needs to change to:

   if (!*done)
     return SVN_NO_ERROR;

I'm thinking of removing the latest TSVN release from the download
servers since this will crash every time a repository is accessed with
windows authentication - which most companies use.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2012-10-09 21:50:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.