[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1396184 - in /subversion/branches/auto-props-sdc/subversion: include/svn_props.h libsvn_client/add.c libsvn_client/client.h libsvn_client/commit.c tests/cmdline/autoprop_tests.py tests/cmdline/svntest/main.py

From: Paul Burba <ptburba_at_gmail.com>
Date: Tue, 9 Oct 2012 15:30:16 -0400

On Tue, Oct 9, 2012 at 2:55 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
> On Tue, Oct 9, 2012 at 8:46 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>> On Tue, Oct 9, 2012 at 2:41 PM, <pburba_at_apache.org> wrote:
>>> Author: pburba
>>> Date: Tue Oct 9 18:41:55 2012
>>> New Revision: 1396184
>>> URL: http://svn.apache.org/viewvc?rev=1396184&view=rev
>>> Log:
>>> On the auto-props-sdc branch: Rename the reserved property
>>> "svn:config:auto-props" to svn:iprop-auto-props".
>>> First and foremost this is to address cmpilato's concerns, see
>>> http://svn.haxx.se/dev/archive-2012-10/0097.shtml But it is also a bit of
>>> bike-shedding; since the old name contained the word "config" it needlessly
>>> conflated itself with the config file which is home of the traditional
>>> auto-props. I think the new name makes it clearer that these auto-props
>>> are outside of the config file.
>> I liked the use of "config" precisely because this property IS
>> somewhat connected to what is in that file. I am not against dropping
>> config, but if we do, then I would also drop iprop and just make the
>> property be svn:auto-props

I shy away from 'svn:auto-props' because eventually we'll have some
sort of ignores-server-dictated-config via inheritable props and
svn:ignore is already taken, so we probably want some common prefix to
this class of inheritable properties.

> +1.
> I don't like the term "iprop" (assuming that stands for "inheritable
> property"), because as I understood it all properties are inheritable
> (and it's up to the "user" of that property to decide to use it in an
> inheritable manner or not).

Sure, it's up to the user, caller, script, etc., but this is a
reserved property that Subversion itself will always consider
inheritable, so I don't believe "iprop" is misleading in any way.

Regardless, I don't feel very strongly about this one way or the
other. Barring any prop-"iprop" feedback I'll switch it to
'svn:config-auto-props' in the near future.

Paul T. Burba
CollabNet, Inc. -- www.collab.net -- Enterprise Cloud Development
Skype: ptburba
> --
> Johan
Received on 2012-10-09 21:30:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.