[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1393521 - in /subversion/trunk/subversion: include/svn_props.h tests/cmdline/svnlook_tests.py

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 5 Oct 2012 10:12:58 -0400

On 10/05/2012 09:30 AM, Mark Phippard wrote:
> On Fri, Oct 5, 2012 at 9:26 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>
>> My understanding was that the namespaces were kinda treated like opaque
>> strings, so "nesting" isn't really even interesting from an XML parser
>> standpoint so much as mere "uniqueness" is.
>>
>> Top answer here (plus the "nit" comment thereupon) seems to confirm as much:
>> http://stackoverflow.com/questions/588919/what-is-the-practice-for-nesting-xml-namespaces
>
> I notice you have not backed out your change, so what is the net
> result of all of this?
>
> I am assuming you committed your patch because you did not see a
> problem. Is it just that expat does not validate the namespace but
> this could be a problem with some other XML parser?

That's right. Expat just doesn't care. Some other XML parser might. But
then, I would expect that same parser would croak on any property name with
a colon in it (besides "svn:", which we handle specially already). So all
of TortoiseSVN's properties, cvs2svn's properties, etc. -- all that stops
working.

> Given that, what does it mean for your change, and possibly Paul's
> branch? Should you go back to using the dash?

I don't think so. I think that would be just a lovely instance of the
perfect being the enemy of the good [enough]. If it becomes a real-world
problem, our recourse is rather straightforward -- we continue our move away
from the DAV standard and implement our own custom POST/REPORT handling.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-10-05 16:13:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.