[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1394345 - /subversion/trunk/subversion/libsvn_fs_fs/caching.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 5 Oct 2012 10:14:20 +0200

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: vrijdag 5 oktober 2012 03:54
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1394345 -
> /subversion/trunk/subversion/libsvn_fs_fs/caching.c
>
> Author: stefan2
> Date: Fri Oct 5 01:54:12 2012
> New Revision: 1394345
>
> URL: http://svn.apache.org/viewvc?rev=1394345&view=rev
> Log:
> Since zero-copy code can cause cache functions to actually return
> an error (lost connection etc.), we must make sure these get passed
> through to the calling functions.
>
> * subversion/libsvn_fs_fs/caching.c
> (warn_on_cache_errors): don't swallow the error, just log it
>
> Modified:
> subversion/trunk/subversion/libsvn_fs_fs/caching.c
>
> Modified: subversion/trunk/subversion/libsvn_fs_fs/caching.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/ca
> ching.c?rev=1394345&r1=1394344&r2=1394345&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/libsvn_fs_fs/caching.c (original)
> +++ subversion/trunk/subversion/libsvn_fs_fs/caching.c Fri Oct 5 01:54:12
> 2012
> @@ -103,8 +103,7 @@ warn_on_cache_errors(svn_error_t *err,
> {
> svn_fs_t *fs = baton;
> (fs->warning)(fs->warning_baton, err);
> - svn_error_clear(err);
> - return SVN_NO_ERROR;
> + return err;
> }

Usually warnings are non-fatal (/non errors). Maybe you should rename this function or handle specific errors?

        Bert
Received on 2012-10-05 10:15:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.