[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix bad tto parameter to apr_memcache_server_create()

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 28 Sep 2012 16:38:28 -0400

...and proposed for backport to 1.7.7.

On 09/28/2012 04:35 PM, C. Michael Pilato wrote:
> Looks good. Committed in r1391641.
>
> On 09/28/2012 02:44 PM, Jeff Trawick wrote:
>> Index: libsvn_subr/cache-memcache.c
>> ===================================================================
>> --- libsvn_subr/cache-memcache.c (revision 1391584)
>> +++ libsvn_subr/cache-memcache.c (working copy)
>> @@ -470,7 +470,8 @@
>> 0, /* min connections */
>> 5, /* soft max connections */
>> 10, /* hard max connections */
>> - 50, /* connection time to live (secs) */
>> + apr_time_from_sec(50), /*
>> connection time
>> + * to live */
>> &server);
>> if (apr_err != APR_SUCCESS)
>> {
>>
>> The ttl is in microseconds, not seconds.
>>
>> I haven't compiled it! (Is it conceivable that apr_time.h isn't available?)
>>
>> This is related to APR bug 51511, which I mistakenly took as an APR bug.
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51511
>>
>> Fold spindle or mutilate as desired!
>>
>
>

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-09-28 22:39:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.