[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 25 Sep 2012 11:01:44 -0400

On 09/25/2012 10:42 AM, Branko Čibej wrote:
> On 25.09.2012 16:37, C. Michael Pilato wrote:
>> +1 on the optional libproxy dependency. That makes great sense to me.
>>
>> However ... since the env-var stuff is *relatively* straightforward, would
>> we be interested in/willing to *also* implement that (or a subset thereof)
>> directly in our codebase for non-Windows, non-Mac use only? Or is that just
>> begging to confuse our users?
>
> If the env-var parsing is implemented in a way that is compatible with
> libproxy, and it's disabled and completely replaced by libproxy when the
> latter is enabled/available, then sure, there's no reason not to have
> both. As long as someone is prepared to maintain both.
>
> But if the proxy-detection behaviour changes noticeably when switching
> from the built-in implementation to what libproxy gives us (always
> remembering that libproxy will have a superset of the features), then
> I'd think twice about such a two-pronged approach.

Yes, I concur on all points.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-09-25 17:02:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.