[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add support for http_proxy and https_proxy environment variables

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 25 Sep 2012 10:37:58 -0400

On 09/17/2012 09:34 PM, Bert Huijben wrote:
> On Windows this isn't the normal way to fetch the system wide proxy, nor
> is it on the Mac. Adding environment flags to GUI applications there is
> certainly *not* the right way to look at this problem. The linux specific
> environment variable solution might apply to a linux gui, but not to a
> Windows gui or a Windows/Mac shell or application extension.
>
> My earlier suggestion was to use libproxy, as that handles the normal
> settings on all these platforms. On Linux it appears to use these proxy
> environment variables (and a few others) as that appears to be the common
> way to configure a proxy there, while on the Mac and Windows it properly
> looks at the system proxy settings. It also handles corner cases like the
> support for ignoring proxies for specific hosts.
>
> As libproxy is LGPL I don't think we can add it as an explicit
> dependency, but adding it as an optional dependency would be a proper
> solution. When encapsulated properly we can also add specific
> implementations for other platforms ourselves. (Windows XP and later
> appear to have a standard API that handles all kinds of proxies,
> including pac files which would require some Mozilla components via
> libproxy)

+1 on the optional libproxy dependency. That makes great sense to me.

However ... since the env-var stuff is *relatively* straightforward, would
we be interested in/willing to *also* implement that (or a subset thereof)
directly in our codebase for non-Windows, non-Mac use only? Or is that just
begging to confuse our users?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-09-25 16:38:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.