[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1387981 - /subversion/branches/10Gb/BRANCH-README

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Thu, 20 Sep 2012 23:35:51 +0200

On Thu, Sep 20, 2012 at 9:22 PM, Branko Čibej <brane_at_wandisco.com> wrote:

> On 20.09.2012 13:41, stefan2_at_apache.org wrote:
> > +Bottlenecks to address:
> > +
> > +* frequent cancellation checks (intense OS interaction)
>
> I don't understand this part: since when do cancellation checks involve
> interaction with the OS? I thought the cancellation flag was an (atomic,
> volatile) thing that requires neither cpu-level atomic operations, nor
> higher-level locking.
>

It may not actually be "the OS" but the phenomenon is real.
check_for_error() in ra_svn/editorp.c calls apr_poll(), which in
turn calls select().

To make things worse, we buffer small output data like props
etc. but check for errors after each of them. So, more select()
calls then socket writes ...

My idea is to short-circuit the check until at least x amount
of data has been sent.

-- Stefan^2.

-- 
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*
Received on 2012-09-20 23:36:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.