Re: svn commit: r1387560 - in /subversion/branches/compressed-pristines/subversion/libsvn_wc: wc_db.c wc_db_private.h wc_db_wcroot.c

ashod_at_apache.org writes:

> Author: ashod
> Date: Wed Sep 19 12:45:24 2012
> New Revision: 1387560
>
> URL: http://svn.apache.org/viewvc?rev=1387560&view=rev
> Log:
> Improved create_pristine_db and tests are passing again.

The small commits are good but the log message should still detail the
changes.

> URL: http://svn.apache.org/viewvc/subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_private.h?rev=1387560&r1=1387559&r2=1387560&view=diff
> ==============================================================================
> --- subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_private.h (original)
> +++ subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_private.h Wed Sep 19 12:45:24 2012
> @@ -127,6 +127,13 @@ svn_wc__db_pdh_create_wcroot(svn_wc__db_
> apr_pool_t *result_pool,
> apr_pool_t *scratch_pool);
>
> +/* Creates a Pristine DB. */
> +svn_error_t *
> +create_pristine_db(svn_sqlite__db_t **pdb,
> + const char *dir_abspath,
> + const char *pdb_fname,
> + apr_pool_t *result_pool,
> + apr_pool_t *scratch_pool);

As a private wc function it should be called svn_wc__create_pristine.

> --- subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_wcroot.c (original)
> +++ subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_wcroot.c Wed Sep 19 12:45:24 2012
> @@ -505,10 +505,9 @@ svn_wc__db_wcroot_parse_local_abspath(sv
> SVN_ERR(svn_sqlite__exec_statements(sdb,
> STMT_VERIFICATION_TRIGGERS));
> #endif
> - /* Open the Pristine DB. */
> - err = svn_wc__db_util_open_db(&pdb, local_abspath, PDB_FILE,
> - svn_sqlite__mode_readwrite, NULL,
> - db->state_pool, scratch_pool);
> + /* Open/Create the Pristine DB. */
> + create_pristine_db(&pdb, local_abspath, PDB_FILE,
> + db->state_pool, scratch_pool);

                 err = svn_wc__create_pristine(...

> if (err == NULL)
> {
> break;
>

-- 
Philip