[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Excessive memory use with "SVNPathAuthz short_circuit"

From: Roderich Schupp <roderich.schupp_at_gmail.com>
Date: Wed, 19 Sep 2012 10:24:29 +0200

On Tue, Sep 18, 2012 at 9:11 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> ...
> The problem is that when
> dav_svn__allow_read calls allow_read_bypass (which is subreq_bypass)
> this pool can't be passed and the request pool is used.
>
> I'm not sure how best to solve this. Your patch certainly is one
> solution. Ideally we would be using the iteration pool in
> detect_changed and passing it on to subreq_bypass but I'm not sure how
> to achieve that.

Change the definition of authz_svn__subreq_bypass_func_t (adding a
pool parameter)
and its one and only implementation subreq_bypass?
Since this definition is in include/mod_authz_svn.h (i.e. it's a
public interface):
are there any "out of tree" implementations that may be affected by this?

Cheers, Roderich
Received on 2012-09-19 10:25:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.