On Fri, Sep 14, 2012 at 07:14:14PM -0000, cmpilato_at_apache.org wrote:
> Author: cmpilato
> Date: Fri Sep 14 19:14:13 2012
> New Revision: 1384889
>
> URL: http://svn.apache.org/viewvc?rev=1384889&view=rev
> Log:
> * subversion/libsvn_ra_serf/util.c
> (expat_response_handler): Avoid parsing errorful responses as XML,
> as suggested by the '###' comment this change alleviates.
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_serf/util.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=1384889&r1=1384888&r2=1384889&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Fri Sep 14 19:14:13 2012
> @@ -2418,9 +2418,8 @@ expat_response_handler(serf_request_t *r
> XML_SetCharacterDataHandler(ectx->parser, expat_cdata);
> }
>
> - /* ### should we bail on anything < 200 or >= 300 ??
> - ### actually: < 200 should really be handled by the core. */
> - if (ectx->handler->sline.code == 404)
> + /* ### TODO: sline.com < 200 should really be handled by the core */
^^^^
Shouldn't this say 'sline.code'?
The dotcom boom has been over for a while!
> + if ((ectx->handler->sline.code < 200) || (ectx->handler->sline.code >= 300))
> {
> /* By deferring to expect_empty_body(), it will make a choice on
> how to handle the body. Whatever the decision, the core handler
>
Received on 2012-09-14 22:07:16 CEST