Re: svn commit: r1381938 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

On Fri, Sep 7, 2012 at 12:56 PM, <stefan2_at_apache.org> wrote:
> Author: stefan2
> Date: Fri Sep 7 08:56:50 2012
> New Revision: 1381938
>
> URL: http://svn.apache.org/viewvc?rev=1381938&view=rev
> Log:
> Partly implements issue #3372: When building the rep state read
> sequence along the skip-delta chain, re-use file instances that
> pertain to the same pack file.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (create_rep_state_body): re-use the last file instance, if possible
> (create_rep_state): extended docstring to cover new parameters
> (build_rep_list): provide hints
> (read_window): seek before read as the file object may be shared
Hi Stefan,

Did you consider using apr_file_dup2() to save disk access, but do not
worry about seek to right position when reading data?

> (svn_fs_fs__get_file_delta_stream,
> verify_walker): adapt callers not using hints
>

-- 
Ivan Zhakov