Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

On Mon, Sep 10, 2012 at 12:58 AM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:

> On Thu, Sep 6, 2012 at 11:30 PM, <stefan2_at_apache.org> wrote:
> > Author: stefan2
> > Date: Thu Sep 6 21:30:40 2012
> > New Revision: 1381766
>

> > +
> > + /* The remaining odd bytes will be examined the naive way: */
> > + for (; ; ++data)
> > + if (*data <= 0)
> > + return data;
> > +
> > + return data;
>
> I get a compiler warning here (VS 2010):
>
>
> c:\research\svn\client_build\trunk2\subversion\libsvn_subr\utf_validate.c(328):
> warning C4702: unreachable code
>
> It seems that last "return data;" is superfluous, since the loop above
> it can only end by returning?
>

Thanks for pointing that out, Johan!
Fixed in r1383640.

-- Stefan^2.

-- 
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*