Re: svn commit: r1382204 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

On Sat, Sep 8, 2012 at 3:59 AM, Peter Samuelson <peter_at_p12n.org> wrote:

>
> > for (; len > 0; ++data, --len)
> > - if (*data < 0)
> > - return data;
> > + if (*data < 0 || *data >= 0x80)
> > + return data;
>
> A reasonable compiler will collapse it anyway, but this is shorter and
> more direct:
>
> if (*data & 0x80)
>

You are right. I'm just using the same pattern
as for the "<=" variant.

-- Stefan^2.

-- 
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*