[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1382028 - in /subversion/trunk/subversion: include/svn_config.h libsvn_subr/cmdline.c libsvn_subr/config_file.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 7 Sep 2012 10:51:18 -0400

On 09/07/2012 10:14 AM, Stefan Küng wrote:
> On 07.09.2012 16:07, Mark Phippard wrote:
>> On Fri, Sep 7, 2012 at 10:04 AM, C. Michael Pilato <cmpilato_at_collab.net
>> <mailto:cmpilato_at_collab.net>> wrote:
>>
>> On 09/07/2012 09:57 AM, Mark Phippard wrote:
>> > Shouldn't this default to 'yes' to match the current behavior?
>>
>> I went with Joe Orton's explicit suggestion (and Karl's implicit
>> approval
>> thereof) that we break compatibility and change the default
>> behavior. See
>> http://svn.haxx.se/dev/archive-2008-07/0161.shtml. That said, as
>> much of a
>> grump as I tend to be about such things, yes, I probably should have
>> coded
>> to my conviction and set the default as 'yes'.
>>
>>
>> I do not really have a strong opinion on it. I cannot imagine anyone
>> likes the current default.
>
> Well, actually I think most users do. At least TSVN users:
> if a cert file is requested, TSVN tells the user and asks for the file. The
> user then selects the file and TSVN automatically adjusts the config (if the
> checkbox is set) so that it never asks for that file again.
> Basically, that saves the user from having to edit the config file manually.
>
> Without asking for the file if the server requests one this would be much
> more complicated: an admin would either have to configure this for every
> user, or write a lengthy doc on how users have to configure it themselves.

I may be wrong, but I kinda get the sense that the GUI clients take their
pick of which Subversion runtime config options make sense for them to
honor. At the moment, the only code which honors the state of the new
configuration variable is the svn_cmdline_* stuff that builds the initial
auth baton. I can't imagine that TSVN and other GUI clients which such
slick UI features use that function -- which is strictly aimed at
command-line utility -- anyway. So can you simply still choose to
unconditionally add the client-cert prompt provider to the TSVN auth baton
provider array?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-09-07 16:51:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.