Re: svn commit: r1380311 - /subversion/trunk/build/generator/templates/svn_locale.vcxproj.ezt

Роман Донченко wrote on Tue, Sep 04, 2012 at 22:13:34 +0400:
> I thought the fix was obvious because the presence of the
> NMake*CommandLine elements indicates it ought to be a Makefile
> project (cf. zlib.vcxproj.ezt); but if you think I'm overstepping my
> boundaries here, then sure, I'll go through you next time.

Don't make it personal. Next time, if you're not sure whether something
is an obvious fix, just ask on dev@ or IRC. This time, to go forward
just explain the technical reason for the commit. (The conversation
might end up in the commit being retroactively +1'd by a full committer,
or in a consensus that your patch should be amended or reverted.)
Received on 2012-09-05 19:52:55 CEST