[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Svn Commit and unlock notifications

From: Markus Schaber <m.schaber_at_3s-software.com>
Date: Tue, 4 Sep 2012 08:38:28 +0000

Hi,

When svn_wc_notify_func2 is called with notify->action == svn_wc_notify_commit_modified, the field notify->lock_state is set to svn_wc_notify_lock_state_unknown (value 1) instead of svn_wc_notify_lock_state_unlocked.

There also is no further notification that the lock is removed, the svn_wc_notify_commit_postfix_txdelta notification equally carries svn_wc_notify_lock_state_unknown.

This happens with SharpSVN based on SVN 1.7.5, and may also affect the other svn_wc_notify_commit_XXX notifications (not checked yet).

Is this intentional, or a bug?

I know that setting the lock state to unlocked when the svn_wc_notify_commit_modified notification is sent might be a little too early (as the commit still might fail), but then there should be a separate unlocking notification at the time when the unlock actually takes place.

My current workaround is that my code memorizes all the pathes where a svn_wc_notify_commit_XXX notifications occurs, and after the commit operation has finished successfully, it assumes all those pathes have been unlocked.

Can someone confirm that this will catch all unlockings? Or do I need to I re-check using svn_client_status5 to avoid false positives?

Thanks a lot,

Markus Schaber

-- 
___________________________
We software Automation.
3S-Smart Software Solutions GmbH
Markus Schaber | Developer
Memminger Str. 151 | 87439 Kempten | Germany | Tel. +49-831-54031-0 | Fax +49-831-54031-50
Email: m.schaber@3s-software.com | Web: http://www.3s-software.com 
CoDeSys internet forum: http://forum.3s-software.com
Download CoDeSys sample projects: http://www.3s-software.com/index.shtml?sample_projects
Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915 
Received on 2012-09-04 10:39:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.