Re: [PATCH] Remove NLS check from kwallet.m4 (was Re: Does KWallet support really need NLS on?)

Raphael Kubo da Costa wrote on Mon, Sep 03, 2012 at 08:15:11 -0300:
> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
>
> > Arfrever Frehtes Taifersar Arahesis wrote on Sun, Sep 02, 2012 at 22:11:11 +0200:
> >> We need to decide if we support GCC <4.3.0 on GNU systems.
> >
> > Can't kwallet.m4 only require --enable-nls if the compiler is gcc <4.3 ?
>
> Or if building some version of Arfrever's test code fails? Speaking of

+1

> that, isn't the problem of disabling NLS, including
> svn_private_config.h and risking including something else which may use
> libintl.h independent of the kwallet code?

Are you talking about order of includes --- a header included after
svn_private_config.h possibly redefining the '_' macro? Or are you
talking about link-time or run-time issues?
Received on 2012-09-03 19:58:21 CEST